From 2dded296b1bdf4e8deff9d5eae39ca7a1c10720a Mon Sep 17 00:00:00 2001
From: uvok cheetah
Date: Tue, 31 Oct 2023 17:09:08 +0100
Subject: Linting!

indentation, naming, quoting, parameters, modes
---
 roles/common/tasks/main.yml | 2 +-
 roles/dns/tasks/main.yml    | 2 +-
 roles/router/tasks/main.yml | 5 +++--
 roles/router/tasks/tinc.yml | 7 +++++--
 4 files changed, 10 insertions(+), 6 deletions(-)

(limited to 'roles')

diff --git a/roles/common/tasks/main.yml b/roles/common/tasks/main.yml
index bf2dd00..627190f 100644
--- a/roles/common/tasks/main.yml
+++ b/roles/common/tasks/main.yml
@@ -1,5 +1,5 @@
 ---
-- name: install basic
+- name: Install basic
   package:
     name:
       - rsync
diff --git a/roles/dns/tasks/main.yml b/roles/dns/tasks/main.yml
index 0a2120b..d824945 100644
--- a/roles/dns/tasks/main.yml
+++ b/roles/dns/tasks/main.yml
@@ -1,5 +1,5 @@
 ---
-- name: install DNS software
+- name: Install DNS software
   package:
     name:
       - dnsmasq
diff --git a/roles/router/tasks/main.yml b/roles/router/tasks/main.yml
index ee09493..c319b4a 100644
--- a/roles/router/tasks/main.yml
+++ b/roles/router/tasks/main.yml
@@ -1,5 +1,5 @@
 ---
-- name: install routing software
+- name: Install routing software
   package:
     name:
       - tinc
@@ -13,9 +13,10 @@
     - tinc is defined
     - tinc.configure is defined
     - tinc.configure
-- name: copy munin plugin
+- name: Copy munin plugin
   copy:
     src: munin_bird
     dest: /usr/local/share/munin/plugins/bird
+    mode: '0750'
   tags:
     - munin
diff --git a/roles/router/tasks/tinc.yml b/roles/router/tasks/tinc.yml
index 682fa0f..2673a59 100644
--- a/roles/router/tasks/tinc.yml
+++ b/roles/router/tasks/tinc.yml
@@ -1,21 +1,25 @@
+---
 - name: Ensure tinc directory exists
   ansible.builtin.file:
     path: '/etc/tinc/tn_int/'
     state: directory
+    mode: '0750'
 - name: Install tinc.conf template
   template:
     src: tinc.conf.j2
     dest: /etc/tinc/tn_int/tinc.conf
+    mode: '0750'
   tags:
     - tconfig
 - name: Install tinc-up template
   template:
     src: tinc-up.j2
     dest: /etc/tinc/tn_int/tinc-up
+    mode: '0740'
   tags:
     - tconfig
 - name: Copy remaining files
-  synchronize:
+  ansible.posix.synchronize:
     src: tn_int/
     dest: /etc/tinc/tn_int/
     archive: false
@@ -26,7 +30,6 @@
     path: "/etc/tinc/tn_int/{{ item }}"
     mode: "0740"
   with_items:
-    - tinc-up
     - tinc-down
   tags:
     - exec
-- 
cgit v1.2.3