Linting

1 files changed, 10 insertions, 10 deletions

diff --git a/src/gpio.cpp b/src/gpio.cpp
index 0d852b9..8b227bb 100644
--- a/src/gpio.cpp
+++ b/src/gpio.cpp
@@ -49,16 +49,16 @@ static struct
 } gpio_task_stuff;
 
 static ARDUINO_ISR_ATTR void gpio_pin_irq(void *);
-static void gpio_loop(void *);
+__attribute__((noreturn)) static void gpio_loop(void *);
 
 //! Create task, initialize pins...
-void de::uvok::badge::gpio_init(void)
+void de::uvok::badge::gpio_init()
 {
     gpio_task_stuff.queue_handle =
         xQueueCreateStatic(4, sizeof(pin_notification_t), &(gpio_task_stuff.queue_storage[0]), &gpio_task_stuff.queue);
 #if UVOK_EPAP_BOARD == BOARD_ESP32_CROWPANEL
-    uint8_t inPins[] = {HOME_KEY, EXIT_KEY, HOME_KEY, NEXT_KEY, OK_KEY, PRV_KEY};
-    for (uint8_t p : inPins)
+    const uint8_t inPins[] = {HOME_KEY, EXIT_KEY, HOME_KEY, NEXT_KEY, OK_KEY, PRV_KEY};
+    for (const uint8_t p : inPins)
     {
         pinMode(p, GPIO_MODE_INPUT);
         // simply use pin number as arg
@@ -68,20 +68,20 @@ void de::uvok::badge::gpio_init(void)
 #endif
 
     // ** TASK AFTER QUEUE ** !!!
-    xTaskCreateStatic(gpio_loop, "gpio", GPIO_STACK, NULL, configMAX_PRIORITIES - 1, gpio_task_stuff.task_stack,
+    xTaskCreateStatic(gpio_loop, "gpio", GPIO_STACK, nullptr, configMAX_PRIORITIES - 1, gpio_task_stuff.task_stack,
                       &gpio_task_stuff.task);
 }
 
 static volatile uint32_t event;
 
 // "Poll task", for button 0.
-de::uvok::badge::gpio_poll_result_t de::uvok::badge::gpio_poll(void)
+de::uvok::badge::gpio_poll_result_t de::uvok::badge::gpio_poll()
 {
     if (event)
     {
-        uint32_t r = event;
+        const uint32_t r = event;
         event = 0;
-        return {.duration_ms = (uint16_t)(r >> 8), .pin_number = (uint8_t)(r & 0xff), .has_data = true};
+        return {.duration_ms = static_cast<uint16_t>(r >> 8), .pin_number = static_cast<uint8_t>(r & 0xff), .has_data = true};
     }
 
     return {0};
@@ -90,8 +90,8 @@ de::uvok::badge::gpio_poll_result_t de::uvok::badge::gpio_poll(void)
 //! GPIO task loop, read / handle queue.
 static void gpio_loop(void *ctx)
 {
-    Serial.println("Starting GPIO loop");
-    while (1)
+    LOG_F("Starting GPIO loop\n");
+    while (true)
     {
         pin_notification_t received;
         if (xQueueReceive(gpio_task_stuff.queue_handle, &received, portMAX_DELAY) == pdTRUE)